Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shuffle the config loading to make it available earlier #310

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Shuffle the config loading to make it available earlier #310

merged 1 commit into from
Feb 1, 2021

Conversation

vkatsuba
Copy link
Contributor

Our configuration loading and checking always had problems
with when to load and apply what. This reshuffle the part
to separate configuration validation and the actual application
of the handler and socket config.

@vkatsuba vkatsuba requested a review from a team January 29, 2021 17:41
@vkatsuba vkatsuba changed the title shuffle the config loading to make it available earlier Shuffle the config loading to make it available earlier Jan 29, 2021
@vkatsuba vkatsuba linked an issue Jan 29, 2021 that may be closed by this pull request
Shuffle the config loading to make it available earlier #311
Closed
@vkatsuba vkatsuba force-pushed the improvement/load_config branch 3 times, most recently from a5dd068 to 9540263 Compare January 29, 2021 18:57
@vkatsuba vkatsuba added the WIP 🚧 Work In Progress label Jan 29, 2021
@RoadRunnr
shuffle the config loading to make it available earlier
f193671 
Our configuration loading and checking always had problems
with when to load and apply what. This reshuffle the part
to separate configuration validation and the actual application
of the handler and socket config.
@vkatsuba vkatsuba removed the WIP 🚧 Work In Progress label Jan 29, 2021
@vkatsuba vkatsuba mentioned this pull request Jan 29, 2021
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.659% when pulling f193671 on improvement/load_config into 040a303 on master.

@vkatsuba vkatsuba merged commit 483399f into master Feb 1, 2021
@vkatsuba vkatsuba deleted the improvement/load_config branch February 1, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoadRunnr RoadRunnr RoadRunnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shuffle the config loading to make it available earlier
3 participants
@vkatsuba @coveralls @RoadRunnr